Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update default LXD meta-data with user meta-data #5584

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

holmanb
Copy link
Member

@holmanb holmanb commented Aug 5, 2024

Proposed Commit Message

fix: Update default LXD meta-data with user meta-data

This was previously unnecessary because:

a. LXD automatically appends the user.meta-data key to default meta-data.
b. In the presence of duplicate keys, PyYAML uses the last key.

This change is part of a series of changes that will enable cloud-init to
avoid depending on undefined behavior. In the future LXD may stop appending
user-defined meta-data to its default meta-data. This change makes
cloud-init forward compatible to LXD for when that change is implemented.

GH-5575

Additional context

Fixes #5575.
Should make cloud-init forward compatible with LXD changes which might be made to address canonical/lxd#13853

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TheRealFalcon TheRealFalcon self-assigned this Aug 5, 2024
@holmanb holmanb merged commit c0ffdd4 into canonical:main Aug 5, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cloud-init depends on undefined yaml behavior in LXD implementation
2 participants