Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scaleway): Don't override IPv6 routes when IPv4 is not primary #5640

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

NoSuchCommand
Copy link
Contributor

Proposed Commit Message

fix(scaleway): Don't override IPv6 routes when IPv4 is not primary

If an instance in _routed-ip_ mode uses both IPv4 **and** IPv6, but the IPv6 is listed (attached) first, the default IPv6 route may be absent from the final network configuration for systems that do not accept Router Advertisements.

This changes fixes the problem by making sure that routes are appended, not overwritten.

Test Steps

  1. Create an instance with routed-ip-enabled=true but no IP address
  2. Create a routed_ipv6 Flexible IP and attach it to the instance
  3. Create a routed_ipv4 Flexible IP and attach it to the instance
  4. Start the instance
  5. Once fully booted, connect to the instance and ensure it has the expected network configuration, and especially a default IPv6 route

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

If an instance in _routed-ip_ mode uses both IPv4 **and** IPv6, but the
IPv6 is listed (attached) first, the default IPv6 route may be absent
from the final network configuration for systems that do not accept
Router Advertisements.

This changes fixes the problem by making sure that routes are appended,
not overwritten.
@TheRealFalcon TheRealFalcon self-assigned this Aug 29, 2024
Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good but the test in failing on CI. Did you forget to add a mock?

@NoSuchCommand
Copy link
Contributor Author

The change looks good but the test in failing on CI. Did you forget to add a mock?

It should be better now that I pushed a fix.

@TheRealFalcon TheRealFalcon added the CLA signed The submitter of the PR has signed the CLA label Sep 3, 2024
Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TheRealFalcon TheRealFalcon merged commit e30ce6b into canonical:main Sep 3, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA signed The submitter of the PR has signed the CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants