Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix labeler #5697

Merged
merged 1 commit into from
Sep 12, 2024
Merged

ci: fix labeler #5697

merged 1 commit into from
Sep 12, 2024

Conversation

holmanb
Copy link
Member

@holmanb holmanb commented Sep 12, 2024

Proposed Commit Message

ci: fix labeler

Additional Context

The failed job shows this output:

Run actions/labeler@v5
  with:
    repo-token: ***
    configuration-path: .github/labeler.yml
    sync-labels: false
    dot: true
The configuration file (path: .github/labeler.yml) was not found locally, fetching via the api
Error: SyntaxError: Invalid regular expression: /ubuntu/**/: Nothing to repeat
Error: Invalid regular expression: /ubuntu/**/: Nothing to repeat

This PR removes the offending line, which was redundant anyways

So I'm not really sure how to test this, because unlike normal workflows, the base branch runs the labeler job. Per the docs:

When submitting an initial pull request to a repository using the pull_request_target event, the labeler workflow will not run on that pull request because the pull_request_target execution runs off the base branch instead of the pull request's branch

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

@holmanb holmanb force-pushed the holmanb/labeler branch 5 times, most recently from f71a4b2 to 48a2ce0 Compare September 12, 2024 18:33
Copy link
Collaborator

@blackboxsw blackboxsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@holmanb holmanb merged commit b88f910 into canonical:main Sep 12, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants