remove newline injected for cloud-init status --wait #5700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove newline on wait
Signed-off-by: Andrew Nelson <andrew.nelson@canonical.com>
Signed-off-by: Andrew Nelson <andrew.nelson@canonical.com>
holmanb
reviewed
Sep 18, 2024
cloudinit/cmd/status.py
Outdated
| @@ -179,7 +179,7 @@ def print_status(args, details: StatusDetails): | |||
| **details.v1, | |||
| } | |||
| if args.format == "tabular": | |||
| prefix = "\n" if args.wait else "" | |||
| prefix = "" if args.wait else "" | |||
There was a problem hiding this comment.
No need to make this conditional, how about just:
prefix = ""
|
Updated status.py per comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Fixes: GH-5863
Environment details
Cloud-init version: 24.4~3+really24.3.1-0ubuntu1
Operating System Distribution: Ubuntu
Cloud provider, platform or installer type: lxd vm
Test Steps
cloud-init status --wait
Merge type