Mypy fixes

[holmanb]

Proposed Commit Message

fix: type annotations for several modules

Remove those modeles from the override list.

Test Steps

See CI coverage

Merge type

• Squash merge using "Proposed Commit Message"
• Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

[a-dubs]

Left one nit. Also, where did you remove from the override list?

[TheRealFalcon]

One inline question and I think we should be preferring List until 3.9.

[TheRealFalcon]

Would it be better to update the constructor so that the path can only have a string?
E.g., instead of

    def __init__(self):
        self.dhcp_client_path = subp.which(self.client_name)
        if not self.dhcp_client_path:
            raise NoDHCPLeaseMissingDhclientError()

do something like

    def __init__(self):
        dhcp_client_path = subp.which(self.client_name)
        if not dhcp_client_path:
            raise NoDHCPLeaseMissingDhclientError()
        self.dhcp_client_path = dhcp_client_path

[holmanb]

Would it be better to update the constructor so that the path can only have a string?

I'm fine with checking in __init__(), but passing absolute paths to subp isn't necessary and makes the logged commands more noisy to read.

[holmanb]

I think we should be preferring List until 3.9.

Why? What we would gain by preferring the deprecated version? This is forwards compatible and cloud-init's codebase uses list and dict extensively in type annotations where not subscripted.

[TheRealFalcon]

LGTM