Ubuntu/focal: refresh patches to fix daily build recipe #5736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Force inline sftp closure rather than on garbage collection. Without this, pytest causes tracebacks because it cleans up the logger before the final sftp connection is closed, which causes tracebacks after tests exit.
Also: - simplify checkout logic to use local github main branch - add human-friendly job name and reduce redundant words
Add Cloud-Init support for instances running in CloudCIX. IMDS configuration data is served on a link-local IP address at http://169.254.169.254/v1 providing user-data, meta-data and network-config. For more information about the platform, see https://www.cloudcix.com/
In 62ace19 we moved cloud-init-hotplugd.socket earlier in boot, after cloud-config.target. But we didn't remove the dependencies added by default and this might conflict with other units producing non-solvable ordering cycles, see #2081124. Remove the default dependency on sysinit.target added by systemd. LP: #2081124
…#5719) Since Noble is an LTS which supports Ubuntu Pro add integration test coverage for that feature. Bump pycloudlib dependency to 1!9.2 which allows cloud-init integration tests to obtain service_account_email configuration from the .config/pycloudlib.toml: [gce] credentials_path = <path> without the need to also provide `service_account_email` in pycloudlib.toml.
Used fallback datasource is no longer a warning when configured as datasource_list: [ None ] due to commit 28d66ef Drop unnecessary WARNING checks because verify_clean_boot handles warning checks.
This test has some questionable history that has been removed. The main purpose of the test is to ensure that we get a log that the python-version file is written if there's no pre-existing python-version file but there is pre-existing pickle cache. The invalid pickle at the beginning of the test complicated this test. A normal boot will write a valid cache, so we should get no pickle errors on reboot.
Fixes GH-5863 Signed-off-by: Andrew Nelson <andrew.nelson@canonical.com>
The logic in Timed() has defaults which are designed to avoid low-value log messages. A log is only emitted when the threshold is exceeded. Additionally, the log_mode parameter allows the caller to prevent Timed() logs, so that the caller may coalesce the message into another log. - Make timer helper into a context manager. - Add new decorator for timing functions. - Simplify timer helper function, eliminate obsolete logic. - Eliminate redundant logs and timer calls.
refactors existing code to utilize timer codepaths: - replace manual timer implementations in subp.py and sockets.py - replace open() / read() calls with util.load_text_file() where appropriate
Remove those modules from the override list.
patches: - d/p/revert-551f560d-cloud-config-after-snap-seeding.patch
TheRealFalcon
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Use individ commits
Additional Context
daily recipe failure https://launchpadlibrarian.net/751040004/buildlog.txt.gz
Test Steps
Merge type