Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(integration_test): add CLOUD_INIT_PKG setting #5739

Merged

Conversation

aciba90
Copy link
Contributor

@aciba90 aciba90 commented Sep 24, 2024

Proposed Commit Message

feat(integration_test): add CLOUD_INIT_PKG setting
    
Add CLOUD_INIT_PKG to control what specific cloud-init package to
install when CLOUD_INIT_SOURCE is PROPOSED, UPGRADE or points to a ppa.
    
SC-1858

Additional Context

Test Steps

export CLOUD_INIT_PLATFORM=lxd_vm
export CLOUD_INIT_OS_IMAGE=oracular

CLOUD_INIT_CLOUD_INIT_SOURCE=ppa:aciba/us-120-cloud-specific-cloud-init-packaging \
CLOUD_INIT_CLOUD_INIT_PKG=cloud-init-smart-os \
	tox -e integration-tests -- -vvv --pdb tests/integration_tests/modules/test_set_hostname.py::TestHostname::test_hostname

export CLOUD_INIT_CLOUD_INIT_PKG=cloud-init

CLOUD_INIT_CLOUD_INIT_SOURCE=PROPOSED \
	tox -e integration-tests -- -vvv --pdb tests/integration_tests/modules/test_set_hostname.py::TestHostname::test_hostname

CLOUD_INIT_CLOUD_INIT_SOURCE=UPGRADE \
	tox -e integration-tests -- -vvv --pdb tests/integration_tests/modules/test_set_hostname.py::TestHostname::test_hostname

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

@aciba90 aciba90 force-pushed the sc1858-tooling-for-cloud-specific-packages branch from 8cf6c16 to 01b4d52 Compare September 25, 2024 09:17
@aciba90 aciba90 changed the title wip feat(integration_test): add CLOUD_INIT_PKG setting Sep 25, 2024
@aciba90 aciba90 marked this pull request as ready for review September 25, 2024 09:20
@blackboxsw blackboxsw self-assigned this Sep 26, 2024
Add CLOUD_INIT_PKG to control what specific cloud-init package to
install when CLOUD_INIT_SOURCE is PROPOSED, UPGRADE or points to a ppa.

SC-1858
@aciba90 aciba90 force-pushed the sc1858-tooling-for-cloud-specific-packages branch from 01b4d52 to b8eea6a Compare September 27, 2024 14:26
Copy link
Collaborator

@blackboxsw blackboxsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It gives us integration test flexibility to mandate the specific subset of cloud-init packages installed.

Not for this PR: we may at some point need to define a mapping of

  • platform/distro/series TO default_cloud_init_pkg_name

Stable releases will likely not get this update, so we probably will eventually want a dict representing known defaults at some point to avoid accidentally running integration tests with a default setting on an Ubuntu devel series and not testing the virtual package we should be testing because the default is set to cloud-init instead of cloud-init-base or cloud-init-azure if we define cloud-specific packages.

@blackboxsw blackboxsw merged commit e618396 into canonical:main Sep 27, 2024
21 checks passed
@aciba90 aciba90 deleted the sc1858-tooling-for-cloud-specific-packages branch September 30, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants