Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: unbreak pytest-xdist #5829

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Conversation

TheRealFalcon
Copy link
Member

Proposed Commit Message

test: unbreak pytest-xdist

'pytest -n auto' fails with random data in parametrization, so
work around it.

Additional Context

Test Steps

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

'pytest -n auto' fails with random data in parametrization, so
work around it.
@@ -267,12 +267,20 @@ def test_main_sys_argv(
# Non-cloud-config
(mock.Mock(), "#!/bin/bash\n - echo hello", True),
# Something that won't decode to utf-8
(mock.Mock(), os.urandom(100), True),
(mock.Mock(), "RANDOM100", True),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This an the next don't match the comment "won't decode to utf-8".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Push an update

Copy link
Member

@holmanb holmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @TheRealFalcon!

@TheRealFalcon TheRealFalcon merged commit 7ff199a into canonical:main Oct 18, 2024
22 checks passed
@TheRealFalcon TheRealFalcon deleted the unbreak-xdist branch October 18, 2024 15:30
holmanb pushed a commit to holmanb/cloud-init that referenced this pull request Oct 22, 2024
'pytest -n auto' fails with random data in parametrization, so
work around it.
TheRealFalcon added a commit that referenced this pull request Nov 4, 2024
'pytest -n auto' fails with random data in parametrization, so
work around it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants