Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't deadlock when starting network service with systemctl #5935

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

holmanb
Copy link
Member

@holmanb holmanb commented Dec 16, 2024

Proposed Commit Message

fix: don't deadlock when starting network service with systemctl

Additional Context

#5930

Test Steps

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

@holmanb holmanb force-pushed the holmanb/systemd-deadlock branch from 7736535 to 52deab4 Compare December 16, 2024 20:56
cloudinit/config/cc_set_passwords.py Outdated Show resolved Hide resolved
cloudinit/config/cc_set_passwords.py Outdated Show resolved Hide resolved
Copy link
Contributor

@ani-sinha ani-sinha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you can update your comment based on our use case and scenario

# run the second stage in 24.3+. This code therefore exists solely
# for backwards compatibility so that users who think that they
# need to manually start cloud-init (why?) with systemd (again,
# why?) can do so.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I have answered the why part

Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TheRealFalcon TheRealFalcon merged commit bc26e15 into canonical:main Dec 18, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants