Retry on 503 #5938
Retry on 503 #5938
Conversation
TheRealFalcon
force-pushed
the
retry-on-503
branch
from
eb9ebae to
583e263
Compare
| @@ -33,6 +43,7 @@ | |||
| LOG = logging.getLogger(__name__) | |||
|
|
|||
| REDACTED = "REDACTED" | |||
| ExceptionCallback = Optional[Callable[["UrlError"], bool]] | |||
There was a problem hiding this comment.
My goal here is to unify the exception_cb interface used in readurl and wait_for_url as they are currently different.
None of the pre-existing callbacks used the "request_args" argument, and it can also be retrieved from an HTTPError if needed in the future, and calculated it would be harder in wait_for_url(), so I removed it from the callback interface and updated the call points accordingly.
| return to_wait | ||
|
|
||
|
|
||
| def _handle_error( |
There was a problem hiding this comment.
I'm hoping this wouldn't be hard to extend to also modify future request arguments if ever needed in the future...but...YAGNI
| except exceptions.SSLError as e: | ||
| # ssl exceptions are not going to get fixed by waiting a | ||
| # few seconds | ||
| raise UrlError(e, url=url) from e | ||
| except exceptions.HTTPError as e: |
There was a problem hiding this comment.
The isinstance() check is silly now that we can use multiple except arms
| @@ -639,61 +724,60 @@ def dual_stack( | |||
| return (returned_address, return_result) | |||
|
|
|||
|
|
|||
| class HandledResponse(NamedTuple): | |||
There was a problem hiding this comment.
I don't love this honestly, but it provides a more structured way of return stuff from the nested functions in wait_for_url()
Follow-up to #5578
Proposed Commit Message
Additional Context
Test Steps
Merge type