Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: merge 4.2.3 to main #478

Merged
merged 4 commits into from
Sep 18, 2024
Merged

chore: merge 4.2.3 to main #478

merged 4 commits into from
Sep 18, 2024

Conversation

lengau
Copy link
Contributor

@lengau lengau commented Sep 18, 2024

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

mr-cal and others added 3 commits September 16, 2024 10:45
@mr-cal
fix: inject aliased snaps into build environment (#467)
77a3582 
Signed-off-by: Callahan Kovacs <callahankovacs@gmail.com>
@lengau
fix(app): get_arg_or_config gets environment correctly
f6627fb 
Previously, if a value was in the passed Namespace, it would return
that. The correct behaviour however is to check the environment for
the value and return that instead.
@lengau
docs(changelog): add 4.2.3 to changelog
8afd506
@lengau lengau added the merge label Sep 18, 2024
@lengau lengau requested a review from a team September 18, 2024 20:30
@lengau lengau merged commit 616b3f0 into main Sep 18, 2024
7 checks passed
@lengau lengau deleted the release-merge/4.2.3 branch September 18, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tigarmo tigarmo tigarmo approved these changes

@mr-cal mr-cal mr-cal approved these changes

@mattculler mattculler Awaiting requested review from mattculler

Assignees
No one assigned
Labels
merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lengau @tigarmo @mr-cal