-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use correct parallel build count #509
Commits on Sep 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for dc1928f - Browse repository at this point
Copy the full SHA dc1928fView commit details
Commits on Sep 12, 2024
-
feat: add initial FetchService skeleton (#7)
This sets the expected API that clients (the Application) will use: - Creating a fetch-service is done in setup(); - Sessions are created with create_session(), which receives a managed instance because we'll need it to figure out the network gateway; - Sessions are destroyed with teardown_session(); - Stopping the fetch-service is done with shutdown().
Configuration menu - View commit details
-
Copy full SHA for 22909db - Browse repository at this point
Copy the full SHA 22909dbView commit details -
feat: start the fetch-service (#8)
Add a set of utility functions so that FetchService.setup() will spawn a fetch-service if necessary. These utility functions include a function to get the service's (json) status, and a function to tell whether the service is up. Use the $SNAP_USER_COMMON location for the fetch-service snap as a base for the 'config' and 'spool' subdirectories.
Configuration menu - View commit details
-
Copy full SHA for ff76bb5 - Browse repository at this point
Copy the full SHA ff76bb5View commit details -
feat: create/teardown fetch-service sessions (#9)
Session credentials are stored to be used (in the near future) when setting up the http/https proxies. When closing the session, the report obtained from the fetch-service is discarded (for now, until we figure out what to do with it).
Configuration menu - View commit details
-
Copy full SHA for a047ae4 - Browse repository at this point
Copy the full SHA a047ae4View commit details -
feat: configure build instances for fetch-service (#11)
This configuration happens when creating the session. Currently we: - Install the local certificate (added to this repo) - Configure pip, snapd and apt - Refresh apt's package listings to ensure all installations are traceable by the fetch-service This initial implementation *always* refreshes apt listings, even if the project build won't use them (e.g. no stage- or build- packages). In the future we'll be smarter about this. The implementation also only supports LXD instances, just because we need to figure out the instance's gateway address and only the LXD work for that has been done so far. In the future we can support all instance types with a cleaner craft-providers API.
Configuration menu - View commit details
-
Copy full SHA for bdb374c - Browse repository at this point
Copy the full SHA bdb374cView commit details -
fix: set REQUESTS_CA_BUNDLE for the fetch-service env. (#16)
This variable points to the local-ca.crt self-signed certificate, effectively telling requests to trust that certificate when negotiating https requests.
Configuration menu - View commit details
-
Copy full SHA for 6bcddf9 - Browse repository at this point
Copy the full SHA 6bcddf9View commit details -
feat: generate the fetch-service certificate
Recent versions of the fetch-service not longer come with a fixed, "built-in" certificate. Instead, clients are expected to generate their own. To do this, we use a location that is shared among all Craft applications - the key and certificate are generated if not found, and are otherwise shared by all instances of all applications. Fixes #21
Configuration menu - View commit details
-
Copy full SHA for 8c1096d - Browse repository at this point
Copy the full SHA 8c1096dView commit details -
fix: set CARGO_HTTP_CAINFO for the fetch-service env
This lets cargo allow our self-signed certificate when making https requests to its registry. Fixes #20
Configuration menu - View commit details
-
Copy full SHA for 5a369df - Browse repository at this point
Copy the full SHA 5a369dfView commit details -
chore(test): set correct deb mimetype back
Now that the fetch-service's bug is fixed we can revert our temporary change
Configuration menu - View commit details
-
Copy full SHA for ae025ad - Browse repository at this point
Copy the full SHA ae025adView commit details -
feat: dump the fetch-service report
This is temporary - in the near future we'll use the in-memory report to generate a 'proper' manifest, but for now this lets us at least have something to inspect/validate.
Configuration menu - View commit details
-
Copy full SHA for d521195 - Browse repository at this point
Copy the full SHA d521195View commit details -
feat(fetch): default to creating permissive sessions
The strict mode is not yet implemented fully, so until further notice we should create permissive sessions.
Configuration menu - View commit details
-
Copy full SHA for 33595c0 - Browse repository at this point
Copy the full SHA 33595c0View commit details -
fix: use fetch-service's common dir for certificate
The snap's current confinement does not let it access the user's home files, so <home>/.local/... is inaccessible.
Configuration menu - View commit details
-
Copy full SHA for 5827eeb - Browse repository at this point
Copy the full SHA 5827eebView commit details -
Configuration menu - View commit details
-
Copy full SHA for b6caa9c - Browse repository at this point
Copy the full SHA b6caa9cView commit details -
feat: always shutdown the fetch-service
There seems to be a bug currently with creating consecutive sessions, so for now let's always shut down the fetch-service after the managed run is done.
Configuration menu - View commit details
-
Copy full SHA for b7355b5 - Browse repository at this point
Copy the full SHA b7355b5View commit details -
chore: redirect output of 'apt update'
With an open_stream() the output shows up in a single, updating line in brief mode. This output is useful because the call takes a while.
Configuration menu - View commit details
-
Copy full SHA for 15b3c1d - Browse repository at this point
Copy the full SHA 15b3c1dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a6d450 - Browse repository at this point
Copy the full SHA 9a6d450View commit details -
fix: better error if the fetch-service is missing (#55)
This implementation checks the presence of the fetch-service snap through the hardcoded path (/snap/bin/fetch-service). If, in the future, we need a more sophisticated approach we can copy craft-provider's logic for checking the lxd snap through snapd's api. Fixes #36
Configuration menu - View commit details
-
Copy full SHA for a70bf86 - Browse repository at this point
Copy the full SHA a70bf86View commit details -
feat: add an argument to enable the fetch service (#53)
With this commit the fetch-service service is disabled by default; the way to enable it is through a new "--use-fetch-service" command line parameter. This new parameter is initiallly only available to the "pack" command, as the cache-clearing that the service needs precludes the use of other lifecycle commands, and the manifest that the application will create based on the fetch-service's session report is only produced during packing. Fixes #15
Configuration menu - View commit details
-
Copy full SHA for ef85eee - Browse repository at this point
Copy the full SHA ef85eeeView commit details -
feat: proper logging for the fetch-service (#56)
This commit redirects the output of the fetch-service to a file. Since we plan to have the fetch-service outlive the application that spawned it, we need to use bash to redirect the fetch-service's output to a file in a way that persists after the application ends. Fixes #51
Configuration menu - View commit details
-
Copy full SHA for c9ccccf - Browse repository at this point
Copy the full SHA c9ccccfView commit details -
chore: disable port conflict test (#64)
Test is failing due to canonical/fetch-service#208; once that's fixed we can revert this commit. Note that only one of the ports is failing; the proxy port is still giving the expected error output.
Configuration menu - View commit details
-
Copy full SHA for c8e923a - Browse repository at this point
Copy the full SHA c8e923aView commit details -
docs(changelog): add release notes for 4.1.3 (#459)
Signed-off-by: Callahan Kovacs <callahankovacs@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1ae919c - Browse repository at this point
Copy the full SHA 1ae919cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5be3430 - Browse repository at this point
Copy the full SHA 5be3430View commit details
Commits on Sep 13, 2024
-
chore: merge release 4.1.3 into main (#460)
chore: merge release 4.1.3 into main
Configuration menu - View commit details
-
Copy full SHA for 1216017 - Browse repository at this point
Copy the full SHA 1216017View commit details -
Configuration menu - View commit details
-
Copy full SHA for a66b217 - Browse repository at this point
Copy the full SHA a66b217View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d7805a - Browse repository at this point
Copy the full SHA 2d7805aView commit details -
chore: factor run logic outside of try block
This allows applications to override the inner run logic, with the end goal of capturing application specific exceptions and raise appropriate ones for Craft Application to handle. Without the logic split, overriding run to capture exceptions is virtually impossible as the run method holds a generic Exception handler. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Configuration menu - View commit details
-
Copy full SHA for ac73285 - Browse repository at this point
Copy the full SHA ac73285View commit details -
Configuration menu - View commit details
-
Copy full SHA for 41b699e - Browse repository at this point
Copy the full SHA 41b699eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ac3f3d - Browse repository at this point
Copy the full SHA 8ac3f3dView commit details -
Configuration menu - View commit details
-
Copy full SHA for d872bfd - Browse repository at this point
Copy the full SHA d872bfdView commit details
Commits on Sep 16, 2024
-
feat(provider): add a way to clean existing instances
This new parameter to ProviderService.instance() defaults to False and, if True, will cause the service to clean a pre-existing instance and create a new one.
Configuration menu - View commit details
-
Copy full SHA for ba3be78 - Browse repository at this point
Copy the full SHA ba3be78View commit details -
feat: wipe existing instances when using the fetch-service
This is necessary because the fetch-service needs visibility on *all* assets downloaded during a build, so pre-existing instances that might already have existing items cannot be re-used. Fixes #40
Configuration menu - View commit details
-
Copy full SHA for e931a59 - Browse repository at this point
Copy the full SHA e931a59View commit details
Commits on Sep 18, 2024
-
feat: set the fetch-service to idle shutdown
Set it to shutdown after 5 minutes of no live sessions.
Configuration menu - View commit details
-
Copy full SHA for e546fae - Browse repository at this point
Copy the full SHA e546faeView commit details -
feat(docs): update partitions docs (#475)
* feat: update partitions docs & fix autobuild path * Apply suggestions from code review * Apply suggestions from code review Co-authored-by: Michael DuBelko <michael.dubelko@gmail.com> * fix(docs): use Michael's suggested text Co-authored-by: Michael DuBelko <michael.dubelko@gmail.com> * Update docs/howto/partitions.rst Co-authored-by: Sergio Schvezov <sergio.schvezov@canonical.com> * docs: update other reference w/ Sergio's suggestion Co-authored-by: Sergio Schvezov <sergio.schvezov@canonical.com> --------- Co-authored-by: Michael DuBelko <michael.dubelko@gmail.com> Co-authored-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Configuration menu - View commit details
-
Copy full SHA for d448c44 - Browse repository at this point
Copy the full SHA d448c44View commit details -
Configuration menu - View commit details
-
Copy full SHA for f2834d9 - Browse repository at this point
Copy the full SHA f2834d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 616b3f0 - Browse repository at this point
Copy the full SHA 616b3f0View commit details
Commits on Sep 19, 2024
-
feat: models for the craft manifest (#473)
There are three new models: - ProjectManifest, representing the metadata from the project itself and its built artifact; - SessionArtifactManifest, representing the metadata for a single asset that was downloaded during the fetch-service session; - CraftManifest, that ties the first two together and provides the full view of assets downloaded and generated by a build. --------- Co-authored-by: Alex Lowe <alex.lowe@canonical.com>
Configuration menu - View commit details
-
Copy full SHA for 575ac20 - Browse repository at this point
Copy the full SHA 575ac20View commit details
Commits on Sep 20, 2024
-
feat: generate project manifest in managed runs
Add a create_project_manifest() method to the FetchService that, when running in managed mode, creates the yaml for the project metadata in a path that will be later accessed by the host-side service to create the "full" craft manifest.
Configuration menu - View commit details
-
Copy full SHA for e258642 - Browse repository at this point
Copy the full SHA e258642View commit details -
feat: create the final craft manifest
When running with the fetch-service integration enabled, the FetchService service will generate a manifest file containing both metadata about the packed artifact (from the project and the artifact itself) and about the dependencies that were downloaded during the build (from the fetch-service session report).
Configuration menu - View commit details
-
Copy full SHA for 60f3188 - Browse repository at this point
Copy the full SHA 60f3188View commit details -
Configuration menu - View commit details
-
Copy full SHA for e3e079f - Browse repository at this point
Copy the full SHA e3e079fView commit details -
Configuration menu - View commit details
-
Copy full SHA for cb8197e - Browse repository at this point
Copy the full SHA cb8197eView commit details -
feat: support "--platform" for "clean"
This brings 'clean' closer to parity with the other lifecycle commands, and is useful for cases where we want to wipe one of the managed instances, but not all of them. Fixes #425
Configuration menu - View commit details
-
Copy full SHA for 07e89de - Browse repository at this point
Copy the full SHA 07e89deView commit details
Commits on Sep 24, 2024
-
feat: set GOPROXY=direct in fetch-service runs (#489)
The value makes Go download directly from version-controlled repositories, instead of module proxies like the default https://proxy.golang.org. It's currently a requirement for the Go inspector.
Configuration menu - View commit details
-
Copy full SHA for c971a60 - Browse repository at this point
Copy the full SHA c971a60View commit details
Commits on Sep 25, 2024
-
feat: allow strict/permissive fetch-service sessions (#490)
'--use-fetch-service' now takes a mandatory argument defining the type of session to use: "strict" or "permissive". Fixes #487
Configuration menu - View commit details
-
Copy full SHA for d327e60 - Browse repository at this point
Copy the full SHA d327e60View commit details
Commits on Sep 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 63ff3d0 - Browse repository at this point
Copy the full SHA 63ff3d0View commit details
Commits on Oct 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0b10cf6 - Browse repository at this point
Copy the full SHA 0b10cf6View commit details -
feat: mark the fetch-service integration as experimental (#496)
By "mark" we mean: - hide the command-line option from pack's help; - if enabled, warn that this integration is still in development. Fixes #488
Configuration menu - View commit details
-
Copy full SHA for 327ff94 - Browse repository at this point
Copy the full SHA 327ff94View commit details -
feat: add craft-platforms compatibility methods (#495)
Also warns about some pending deprecations.
Configuration menu - View commit details
-
Copy full SHA for 3bd339c - Browse repository at this point
Copy the full SHA 3bd339cView commit details
Commits on Oct 3, 2024
-
fix(docs): fix docs for canonical-sphinx 0.2 (#498)
This replaces the diataxis grid with a list-table. https://docutils.sourceforge.io/docs/ref/rst/directives.html#list-table
Configuration menu - View commit details
-
Copy full SHA for 8b2b8f3 - Browse repository at this point
Copy the full SHA 8b2b8f3View commit details
Commits on Oct 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8b46697 - Browse repository at this point
Copy the full SHA 8b46697View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c3829a - Browse repository at this point
Copy the full SHA 1c3829aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3fdc863 - Browse repository at this point
Copy the full SHA 3fdc863View commit details -
Configuration menu - View commit details
-
Copy full SHA for 72ac884 - Browse repository at this point
Copy the full SHA 72ac884View commit details -
Co-authored-by: Alex Lowe <alex.lowe@canonical.com>
Configuration menu - View commit details
-
Copy full SHA for cb3ceef - Browse repository at this point
Copy the full SHA cb3ceefView commit details
Commits on Oct 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 23b8142 - Browse repository at this point
Copy the full SHA 23b8142View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8567282 - Browse repository at this point
Copy the full SHA 8567282View commit details -
Configuration menu - View commit details
-
Copy full SHA for 90507ae - Browse repository at this point
Copy the full SHA 90507aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for cd2c9a4 - Browse repository at this point
Copy the full SHA cd2c9a4View commit details