Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

providers: pause the emitter before launching inner instance #51

Merged
merged 3 commits into from
Aug 22, 2023

Conversation

sergiusens
Copy link
Collaborator

@sergiusens sergiusens commented Aug 21, 2023

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
@sergiusens sergiusens force-pushed the pause-launch branch 2 times, most recently from 93c6452 to 2627dab Compare August 21, 2023 16:59
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #51 (3444daa) into main (5c7a5fe) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #51   +/-   ##
=======================================
  Coverage   98.95%   98.95%           
=======================================
  Files          20       20           
  Lines         668      669    +1     
  Branches       99      100    +1     
=======================================
+ Hits          661      662    +1     
  Misses          6        6           
  Partials        1        1           
Files Changed Coverage Δ
craft_application/services/provider.py 100.00% <100.00%> (ø)

@sergiusens sergiusens merged commit 2e03268 into main Aug 22, 2023
8 checks passed
@sergiusens sergiusens deleted the pause-launch branch August 22, 2023 12:59
tigarmo added a commit that referenced this pull request Sep 11, 2024
This commit redirects the output of the fetch-service to a file. Since we plan
to have the fetch-service outlive the application that spawned it, we need to
use bash to redirect the fetch-service's output to a file in a way that
persists after the application ends.

Fixes #51
tigarmo added a commit that referenced this pull request Sep 12, 2024
This commit redirects the output of the fetch-service to a file. Since we plan
to have the fetch-service outlive the application that spawned it, we need to
use bash to redirect the fetch-service's output to a file in a way that
persists after the application ends.

Fixes #51
tigarmo added a commit that referenced this pull request Sep 12, 2024
This commit redirects the output of the fetch-service to a file. Since we plan
to have the fetch-service outlive the application that spawned it, we need to
use bash to redirect the fetch-service's output to a file in a way that
persists after the application ends.

Fixes #51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants