feat: pass the app_config to pre_parse_args() #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets commands be able to always rely on `self.config` existing, even when running `fill_parser()` for help output. Fixes #530
tigarmo
force-pushed
the
work/CRAFT-3586-app-config-pre-parse
branch
from
517932c
to
68def0c
Compare
tigarmo
commented
Oct 21, 2024
upils
reviewed
Oct 22, 2024
mr-cal
approved these changes
Oct 22, 2024
lengau
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets commands be able to always rely on
self.configexisting, even when runningfill_parser()for help output.Fixes #530
tox?