Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): use ruff from snap #207

Merged
merged 4 commits into from
Sep 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
echo "::group::Begin snap install"
echo "Installing snaps in the background while running apt and pip..."
sudo snap install --no-wait --classic pyright
sudo snap install --no-wait shellcheck
sudo snap install --no-wait shellcheck ruff
echo "::endgroup::"
echo "::group::pip install"
python -m pip install tox
Expand Down
1 change: 0 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ dev = [
lint = [
"black==24.8.0",
"codespell[toml]==2.3.0",
"ruff==0.6.1",
"yamllint==1.35.1"
]
types = [
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/test_store_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,7 @@ def test_store_client_upload_file_with_monitor(tmp_path, http_client_request_moc
filepath = tmp_path / "artifact.thing"
filepath.write_text("file to upload")

def callback(monitor): # noqa: ARG001
def callback(monitor):
pass

def monitor(encoder): # noqa: ARG001
Expand Down
5 changes: 4 additions & 1 deletion tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ base = testenv, lint
labels = lint
allowlist_externals =
shellcheck: bash, xargs
ruff: ruff
commands_pre =
shellcheck: bash -c '{[shellcheck]find} | {[shellcheck]filter} > {env_tmp_dir}/shellcheck_files'
commands =
Expand Down Expand Up @@ -100,9 +101,11 @@ commands =
description = Automatically format source code
base = testenv, lint
labels = format
allowlist_externals =
ruff: ruff
commands =
black: black {tty:--color} {posargs} .
ruff: ruff --fix --respect-gitignore {posargs} .
ruff: ruff check --fix --respect-gitignore {posargs} .
codespell: codespell --toml {tox_root}/pyproject.toml --write-changes {posargs}

[testenv:pre-commit]
Expand Down
Loading