Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change checks and configuration #79

Merged
merged 5 commits into from
Nov 8, 2024
Merged

fix: change checks and configuration #79

merged 5 commits into from
Nov 8, 2024

Conversation

amandahla
Copy link
Collaborator

This PR:

  • change pebble check threshold from 3 (default) to 2
  • change pebble plan for restart if check fails
  • decrease alert rule from critical to warning
  • change configuration to accept empty values so billing wont be checked by the exporter
  • remove default values for org and API token.

Copy link

github-actions bot commented Nov 7, 2024

Test coverage for a498a82

Name                             Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------------------------
src/charm.py                        52      3      4      1    93%   98-100
src/charm_state.py                  35      1      2      1    95%   21
src/constants.py                     4      0      0      0   100%
src/exceptions.py                    3      0      0      0   100%
src/github_actions_exporter.py      24      0      0      0   100%
----------------------------------------------------------------------------
TOTAL                              118      4      6      2    95%

Static code analysis report

Run started:2024-11-07 17:39:06.806893

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 587
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@amandahla amandahla merged commit 9bcb85c into main Nov 8, 2024
17 checks passed
@amandahla amandahla deleted the ISD-2726-fix branch November 8, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants