Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove min length and change docstring #80

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

amandahla
Copy link
Collaborator

This is a follow-up for the #79.

Removes min_length from charm_state and update docstring as noted by @cbartz (thanks).

Copy link

github-actions bot commented Nov 8, 2024

Test coverage for 8cc3f52

Name                             Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------------------------
src/charm.py                        52      3      4      1    93%   98-100
src/charm_state.py                  35      1      2      1    95%   21
src/constants.py                     4      0      0      0   100%
src/exceptions.py                    3      0      0      0   100%
src/github_actions_exporter.py      24      0      0      0   100%
----------------------------------------------------------------------------
TOTAL                              118      4      6      2    95%

Static code analysis report

Run started:2024-11-08 17:44:56.293252

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 588
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@amandahla amandahla merged commit efa6b59 into main Nov 11, 2024
17 checks passed
@amandahla amandahla deleted the fix-config-valid branch November 11, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants