Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the API not prefixing the FQDN_PREFIX to created domains #56

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

kot0dama
Copy link
Contributor

Overview

Prefix FQDN_PREFIX when adding new domains through the Django REST API.

Rationale

We need the Django REST API to be consistent with what the application or juju action would do.

Checklist

  • The contributing guide was applied
  • The PR is tagged with appropriate label (urgent, trivial, complex)

This is neither urgent, trivial nor complex

Signed-off-by: Loïc Gomez <89980752+kot0dama@users.noreply.github.com>
@kot0dama kot0dama requested a review from a team as a code owner April 14, 2024 05:01
@yanksyoon
Copy link

/canonical/self-hosted-runners/run-workflows 235a799

Copy link

Test coverage for 235a799

Name                                                              Stmts   Miss Branch BrPart  Cover   Missing
-------------------------------------------------------------------------------------------------------------
httprequest_lego_provider/__init__.py                                 1      0      0      0   100%
httprequest_lego_provider/apps.py                                     5      0      0      0   100%
httprequest_lego_provider/dns.py                                     69      0      8      0   100%
httprequest_lego_provider/forms.py                                   22      0      2      0   100%
httprequest_lego_provider/management/__init__.py                      1      0      0      0   100%
httprequest_lego_provider/management/commands/__init__.py             1      0      0      0   100%
httprequest_lego_provider/management/commands/allow_domains.py       22      0      2      0   100%
httprequest_lego_provider/management/commands/create_user.py         15      0      0      0   100%
httprequest_lego_provider/management/commands/list_domains.py        16      0      2      0   100%
httprequest_lego_provider/management/commands/revoke_domains.py      22      0      2      0   100%
httprequest_lego_provider/migrations/0001_initial.py                  8      0      0      0   100%
httprequest_lego_provider/migrations/__init__.py                      0      0      0      0   100%
httprequest_lego_provider/models.py                                  10      0      0      0   100%
httprequest_lego_provider/serializers.py                             20      0      0      0   100%
httprequest_lego_provider/urls.py                                     9      0      0      0   100%
httprequest_lego_provider/views.py                                   54      0      8      0   100%
-------------------------------------------------------------------------------------------------------------
TOTAL                                                               275      0     24      0   100%

Static code analysis report

Run started:2024-04-14 07:43:21.142230

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 1474
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@arturo-seijas arturo-seijas merged commit 8c63bda into canonical:main Apr 15, 2024
13 checks passed
@kot0dama kot0dama deleted the api_add_domain_fqdn branch April 15, 2024 08:47
@kot0dama
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants