Skip to content

Commit

Permalink
feat(ISD-1667): updated snap guidelines to include snaps where the bi…
Browse files Browse the repository at this point in the history
…nary is built from source

undid some automatic markdown formatting
  • Loading branch information
codethulu committed Mar 8, 2024
1 parent 371a690 commit 134b7f5
Showing 1 changed file with 20 additions and 27 deletions.
47 changes: 20 additions & 27 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,31 +1,24 @@
# Standards

- [Standards](#standards)
- [Definitions](#definitions)
- [Tool](#tool)
- [Unit Tests](#unit-tests)
- [Integration Tests](#integration-tests)
- [End To End Tests](#end-to-end-tests)
- [Smoke Tests](#smoke-tests)
- [Programming Languages and Frameworks](#programming-languages-and-frameworks)
- [Charm Ubuntu and Python Version](#charm-ubuntu-and-python-version)
- [Downloading Binaries](#downloading-binaries)
- [CI-CD](#ci-cd)
- [Random Values](#random-values)
- [File Encoding](#file-encoding)
- [Repository Setup](#repository-setup)
- [PR comments and requests for changes](#pr-comments-and-requests-for-changes)
- [Failing Status Checks](#failing-status-checks)
- [Test Structure](#test-structure)
- [Test Exception Raised](#test-exception-raised)
- [Test Fixture](#test-fixture)
- [Test Coverage](#test-coverage)
- [Type Hints](#type-hints)
- [Handling Typing Issues with python-libjuju](#handling-typing-issues-with-python-libjuju)
- [Static Code Analysis](#static-code-analysis)
- [Source Code Documentation](#source-code-documentation)
- [Function and Method Ordering](#function-and-method-ordering)
- [Non Compliant Code](#non-compliant-code)
- [Charm Ubuntu and Python Version](#charm-ubuntu-and-python-version)
- [CI-CD](#ci-cd)
- [Downloading Binaries](#downloading-binaries)
- [Failing Status Checks](#failing-status-checks)
- [File Encoding](#file-encoding)
- [Function and Method Ordering](#function-and-method-Ordering)
- [Handling Typing Issues with python-libjuju](#handling-typing-issues-with-python-libjuju)
- [Non Compliant Code](#non-compliant-code)
- [PR comments and requests for changes](#pr-comments-and-requests-for-changes)
- [Programming Languages and Frameworks](#programming-languages-and-frameworks)
- [Random values](#random-values)
- [Repository Setup](#repository-setup)
- [Static Code Analysis](#static-code-analysis)
- [Source Code Documentation](#source-code-documentation)
- [Test Coverage](#test-coverage)
- [Test Exception Raised](#test-exception-raised)
- [Test Fixture](#test-fixture)
- [Test Structure](#test-structure)
- [Type Hints](#type-hints)

The [Charm development best practices](https://juju.is/docs/sdk/styleguide) are
incorporated by reference.
Expand Down Expand Up @@ -136,7 +129,7 @@ These are:
* The Ubuntu Archives (for debian packages)
* Snaps
[owned by the "canonical" account](https://snapcraft.io/publisher/canonical)
* Snaps where the binary is built from source, and the source is trusted and approved for use
* Snaps where the binary is built from source, and the source is trusted and approved for use.
* [PyPi](https://pypi.org/)

These sources are considered trusted because we are confident that we understand
Expand Down

0 comments on commit 134b7f5

Please sign in to comment.