Add guideline for testing exceptions #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturo-seijas
previously approved these changes
Jan 19, 2024
cbartz
reviewed
Jan 19, 2024
Co-authored-by: Christopher Bartz <christopherbartz@gmx.de>
gtrkiller
previously approved these changes
Jan 19, 2024
cbartz
previously approved these changes
Jan 22, 2024
There was a problem hiding this comment.
I'm wondering if we should have a different rule for the number of approvals required for PR's on this repo (or require approval from @canonical/is-devops-leadership), as PR's on this repo could very likely affect the work of our whole team, and getting 2 quick approvals from teammates might mean that not everyone sees it.
jdkandersson
previously approved these changes
Jan 23, 2024
6 tasks
yanksyoon
reviewed
Jan 23, 2024
Co-authored-by: Christopher Bartz <christopherbartz@gmx.de>
yhaliaw
requested review from
yanksyoon,
cbartz,
jdkandersson,
arturo-seijas and
gtrkiller
cbartz
approved these changes
Feb 14, 2024
jdkandersson
approved these changes
Feb 19, 2024
arturo-seijas
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the changes in
CONTRIBUTING.mdfor the guideline added.