Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Snap guidelines to include Snaps where the binary is built from source #75

Merged
merged 3 commits into from
Mar 14, 2024

Conversation

codethulu
Copy link
Contributor

While working on ISD-1600, we notice that the current charm contributing guide is too restrictive with respect to what Snaps should be used. We aim to resolve this by opening up the accepted Snaps we use internally to include those that are built from source and trusted.

@codethulu codethulu requested a review from a team as a code owner March 8, 2024 11:12
jdkandersson
jdkandersson previously approved these changes Mar 11, 2024
Copy link
Collaborator

@jdkandersson jdkandersson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is a markdown linting error

yanksyoon
yanksyoon previously approved these changes Mar 11, 2024
cbartz
cbartz previously approved these changes Mar 11, 2024
@codethulu codethulu dismissed stale reviews from cbartz, yanksyoon, and jdkandersson via 92dad53 March 14, 2024 14:05
@codethulu codethulu merged commit c323aa6 into main Mar 14, 2024
1 check passed
@codethulu codethulu deleted the feat/ISD-1667 branch March 14, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants