Watch Progress Request #212
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,13 @@ | ||
| module github.com/canonical/k8s-dqlite | ||
|
|
||
| go 1.22.0 | ||
|
|
||
| toolchain go1.22.10 | ||
|
There was a problem hiding this comment. why is this needed? Are we really relying on this specific patch version to build this? There was a problem hiding this comment. I believe |
||
|
|
||
| require ( | ||
| github.com/canonical/go-dqlite/v2 v2.0.0 | ||
| github.com/mattn/go-sqlite3 v1.14.22 | ||
| github.com/onsi/gomega v1.33.1 | ||
| github.com/pkg/errors v0.9.1 | ||
| github.com/prometheus/client_golang v1.19.0 | ||
| github.com/sirupsen/logrus v1.9.3 | ||
|
|
@@ -21,7 +23,7 @@ require ( | |
| go.opentelemetry.io/otel/sdk v1.31.0 | ||
| go.opentelemetry.io/otel/sdk/metric v1.31.0 | ||
| go.opentelemetry.io/otel/trace v1.31.0 | ||
| golang.org/x/sys v0.28.0 | ||
| google.golang.org/grpc v1.67.1 | ||
| gopkg.in/yaml.v2 v2.4.0 | ||
| ) | ||
|
|
@@ -33,6 +35,7 @@ require ( | |
| github.com/cespare/xxhash/v2 v2.3.0 // indirect | ||
| github.com/coreos/go-semver v0.3.1 // indirect | ||
| github.com/coreos/go-systemd/v22 v22.5.0 // indirect | ||
| github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc // indirect | ||
| github.com/dustin/go-humanize v1.0.1 // indirect | ||
| github.com/go-logr/logr v1.4.2 // indirect | ||
| github.com/go-logr/stdr v1.2.2 // indirect | ||
|
|
@@ -41,6 +44,7 @@ require ( | |
| github.com/golang/protobuf v1.5.4 // indirect | ||
| github.com/google/btree v1.1.2 // indirect | ||
| github.com/google/go-cmp v0.6.0 // indirect | ||
| github.com/google/pprof v0.0.0-20240525223248-4bfdf5a9a2af // indirect | ||
| github.com/google/renameio v1.0.1 // indirect | ||
| github.com/google/uuid v1.6.0 // indirect | ||
| github.com/gorilla/websocket v1.5.1 // indirect | ||
|
|
@@ -53,6 +57,8 @@ require ( | |
| github.com/json-iterator/go v1.1.12 // indirect | ||
| github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect | ||
| github.com/modern-go/reflect2 v1.0.2 // indirect | ||
| github.com/onsi/ginkgo/v2 v2.19.0 // indirect | ||
| github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 // indirect | ||
| github.com/prometheus/client_model v0.6.0 // indirect | ||
| github.com/prometheus/common v0.50.0 // indirect | ||
| github.com/prometheus/procfs v0.13.0 // indirect | ||
|
|
@@ -69,11 +75,12 @@ require ( | |
| go.opentelemetry.io/proto/otlp v1.3.1 // indirect | ||
| go.uber.org/multierr v1.11.0 // indirect | ||
| go.uber.org/zap v1.27.0 // indirect | ||
| golang.org/x/crypto v0.30.0 // indirect | ||
| golang.org/x/net v0.32.0 // indirect | ||
| golang.org/x/sync v0.10.0 // indirect | ||
| golang.org/x/text v0.21.0 // indirect | ||
| golang.org/x/time v0.5.0 // indirect | ||
| golang.org/x/tools v0.28.0 // indirect | ||
| google.golang.org/genproto v0.0.0-20240311173647-c811ad7063a7 // indirect | ||
| google.golang.org/genproto/googleapis/api v0.0.0-20241007155032-5fefd90f89a9 // indirect | ||
| google.golang.org/genproto/googleapis/rpc v0.0.0-20241007155032-5fefd90f89a9 // indirect | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We make the watchProgressNotifyInterval configurable.
The watchProgressNotifyInterval is the interval in which we send progress reports on our watchers to the api-server. This interval gets used in watch.go