-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
queue-proxy
container image is not set in the KnativeService
's pod when configured in the charm
#183
Comments
Thank you for reporting us your feedback! The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-5753.
|
Looking a bit around in upstream manifests, it looks like we need to configure the queue-proxy image in this place of the manifests We'll need to ensure we can configure this also via the KnativeServing CR |
Lastly, in those manifests I also see an |
Thanks @kimwnasptd for the pointers.
|
I was not able to reproduce this issue in airgapped today.
I looked into it and filed #185 , after setting the images specified in #185 I no longer see the error above so I can now start playing with editing the configmap and the |
I modified the
to test out if this is what we need for the KnativeService workload. Now I see the KnativeService workload pod description
so this fixes the I also saw the
I will be sending a PR to add the |
After configuring the
The logs of the
I'm not sure now why this is happening so I'm looking into it |
I tried running the dummy ksvc that's in the description in a non-airgapped environment and I was seeing the same error. |
PR is now open #186 to add the config for queue image |
Bug Description
Hit this issue while testing CKF 1.8 in airgapped (related to canonical/bundle-kubeflow#889 and canonical/bundle-kubeflow#898):
When configuring the
queue-proxy
image in the custom images, then creating aKnativeService
, thequeue-proxy
image in theKnativeService
gets the default value, not the one configured in the charm.This is a blocker for using KNative in an airgapped environment.
See #140 for context on configuring the custom images.
Looking at the
knative-serving
charm's config, we can see that the custom image is set there:and Looking at the KnativeServing CR, we can see that the
queue-proxy
field is set there correctly in theregistry
section:However, it is not getting picked up by the
KnativeService
CR's Pod:It still sets the default image in the container^
To Reproduce
queue-proxy
image to the image in the local registry, in my case I set it to172.17.0.2:5000/knative-releases/knative.dev/serving/cmd/queue:dabaecec38860ca4c972e6821d5dc825549faf50c6feb8feb4c04802f2338b8a
queue-proxy
image in the KnativeService pod:pod description
Environment
airgapped environment
microk8s 1.25-strict/stable
juju 3.1/stable
Relevant Log Output
Additional Context
No response
The text was updated successfully, but these errors were encountered: