Fixes integration tests #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claudiubelu
force-pushed
the
fixes-integration-tests
branch
from
51a6aa6
to
ddfbfcb
Compare
bschimke95
reviewed
Sep 16, 2024
There are a few issues running the Longhorn integration tests on an LXD runner, as we currently are, mainly having to do with ISCSI volumes being exposed and mounted in LXD. Running on host has its own issues, mainly the Pods have cluster-wide connectivity issues. Instead, we'll be testing Longhorn in a multipass VM. We also remove some of the GitHub runner's bloat in order to free up sufficient space for the VM and test. Note that according to the Longhorn deployment guide, Longhorn requires 25% of the root disk to be available (if no other disks are available).
According to the deployment guide, the node requires open-iscsi and nfs-common. These daemonsets will install them on the host.
claudiubelu
force-pushed
the
fixes-integration-tests
branch
from
ddfbfcb
to
b328fde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few issues running the Longhorn integration tests on an LXD runner, as we currently are, mainly having to do with ISCSI volumes being exposed and mounted in LXD.
Running on host has its own issues, mainly the Pods have cluster-wide connectivity issues.
Instead, we'll be testing Longhorn in a multipass VM. We also remove some of the GitHub runner's bloat in order to free up sufficient space for the VM and test. Note that according to the Longhorn deployment guide, Longhorn requires 25% of the root disk to be available (if no other disks are available).
According to the deployment guide, the node requires
open-iscsiandnfs-common. These daemonsets will install them on the host.