Cleanup v1.6.2 rocks #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The longhorn-engine rock should contain the longhorn-instance-manager, but longhorn-engine is built and included instead. Removes redundant liblonghorn clone and installation. Removes redundant cd $CRAFT_PART_SRC.
berkayoz
reviewed
Sep 24, 2024
Comment on lines
-99
to
-108
| # NOTE(aznashwan): pull and install liblonghorn | ||
| # https://github.com/longhorn/longhorn-engine/blob/v1.6.2/package/Dockerfile#L12-L19 | ||
| LIBLONGHORN_COMMIT_ID="53d1c063b95efc8d949b095bd4bf04637230265f" | ||
| cd /usr/src | ||
| git clone https://github.com/rancher/liblonghorn.git | ||
| cd liblonghorn | ||
| git checkout ${LIBLONGHORN_COMMIT_ID} | ||
| make | ||
| make install | ||
|
|
There was a problem hiding this comment.
Is this not used at all or included through another build step/part?
There was a problem hiding this comment.
We already have a build-liblonghorn step below, which clones this repo at this commit hash and runs make and make install.
berkayoz
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
longhorn-enginerock should contain thelonghorn-instance-manager, butlonghorn-engineis built and included instead.Removes redundant
liblonghornclone and installation.Removes redundant cd
$CRAFT_PART_SRC.