New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preparation for 4.0.10 (stable-4.0) #13704

Merged

tomponline merged 87 commits into canonical:stable-4.0 from simondeziel:preparation-for-4.0.10

Jul 10, 2024

Member

simondeziel commented Jul 5, 2024 •

edited

Loading

This PR should have a commit list very similar to that of #13643

stgraber and others added 3 commits

July 5, 2024 10:47


          lxd/devlxd: Don't expand format strings

d46d4ac

This must have been around a long time but only became visible now that
cloud-init is making use of /dev/lxd.

Closes canonical#10231

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
(cherry picked from commit 2c5b007)
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>


          lxd/instance/qemu: Set spawn=allow

bc8f74f

spawn=allow is required when QEMU is asked to daemonize.

Previous QEMU versions would incorrectly block `fork` when spawn=deny
was passed while allowing clone to succeed.

This was then making it possible for us to use daemnize thanks to most
Linux distributions using the clone syscall to implement fork.

Current QEMU has fixed their seccomp profile to block both fork and
clone, preventing -daemonize when spawn=deny is passed.

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
(cherry picked from commit af5c49e)
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>


          *: mass rename github.com/lxc/lxd -> github.com/canonical/lxd

b7478f9

```
for f in $(git grep -lF github.com/lxc/lxd); do
    sed -i 's|github.com/lxc/lxd|github.com/canonical/lxd|g' "${f}"
done
```

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>

simondeziel changed the base branch from main to stable-4.0

July 5, 2024 15:14

github-actions bot added Documentation API labels

simondeziel changed the title ~~Preparation for 4.0.10~~ Preparation for 4.0.10 (stable-4.0)

markylaing mentioned this pull request

Enable mTLS for server certificates (stable-4.0) #13705

Merged

simondeziel force-pushed the preparation-for-4.0.10 branch 2 times, most recently from c745c7d to e0807e8 Compare

July 5, 2024 18:38

simondeziel marked this pull request as ready for review

July 5, 2024 21:27

simondeziel requested review from tomponline, ru-fu and markylaing

July 5, 2024 21:27

markylaing reviewed

View reviewed changes

Makefile Outdated Show resolved Hide resolved

ru-fu previously approved these changes

View reviewed changes

Contributor

ru-fu left a comment

Looks good to me.
Great job getting the docs to build again! 👍

doc/metadata.yaml Outdated Show resolved Hide resolved

simondeziel dismissed ru-fu’s stale review via

988ff40

July 8, 2024 13:29

simondeziel force-pushed the preparation-for-4.0.10 branch from 51eafbb to 988ff40 Compare

July 8, 2024 13:29

ru-fu mentioned this pull request

build(deps): bump actions/checkout from 2 to 4 #13715

Closed

simondeziel added the 4.0 LTS label

simondeziel force-pushed the preparation-for-4.0.10 branch 4 times, most recently from baad25f to d55365f Compare

July 9, 2024 04:07


          Makefile: Pin xgettext-go to working version

f7bda31

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
(cherry picked from commit 033ae33)

simondeziel force-pushed the preparation-for-4.0.10 branch 5 times, most recently from 6f32b6b to 1b751ed Compare

July 9, 2024 06:17

simondeziel added 11 commits

July 9, 2024 18:22


          Makefile: use go install instead of go get

15a9081

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>


          po: Run LXD_OFFLINE=1 make update-pot

7fc3603

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>


          po: Run make update-po

259846e

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>


          doc/metadata: Drop now unused file

dd2a7c9

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
(cherry picked from commit 5c60a70)


          doc/requirements: bump Go min to 1.16

144c1ea

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>


          test: drop dependency on uuidgen

0b3fcdc

uuidgen was used to generate a single placeholder remote name.
If we ever want a UUID generator back, we should use:

  `systemd-id128 new -u`

Which doesn't depend on an additional package.

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
(cherry picked from commit 32b92f6)


          test/backends: sync with main branch

82d084e

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>


          test/backends/lvm: use bigger loop dev to accomodate for metadata LV

8d6a60c

On LXD 4.0, the metadata LV is hardcoded to 1G so we need a bigger pool to have
space for data LVs. Later LXD versions changed this to be dynamic and/or
configurable.

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>


          test/includes: sync with main branch

2514af5

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>


          test/main: sync with main branch

f202888

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>


          github: sync triage workflow with main branch

9f475d4

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>

simondeziel force-pushed the preparation-for-4.0.10 branch from a07f3d0 to 724e7ac Compare

July 9, 2024 22:23

simondeziel added 4 commits

July 9, 2024 21:15


          github: sync tests workflow with main branch

3493ec8

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>


          github: remove sphinx workflow (moved to tests)

22cec9f

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>


          test: update shellcheck disable code

a412902

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>


          test/suites/static_analysis: ignore some suggestions from shellcheck

0debb9a

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>

simondeziel force-pushed the preparation-for-4.0.10 branch 2 times, most recently from d7add48 to f6ce644 Compare

July 10, 2024 01:44

simondeziel and others added 8 commits

July 9, 2024 23:07


          test/suites/static_analysis: disable go vet

e173b9e

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>


          test/suites/static_analysis: skip doc/ directory

6fa1631

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>


          github: make sure xgettext-go is available during offline build

ec3cfa4

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>


          test/suites/storage: tune quota values

e3bb6da

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>


          test/suites/migration: skip optimized btrfs->btrfs migration

cb3ec71

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>


          test: BTRFS nospace_cache usage was failing to mount on 5.19.0-43-gen…

…eric

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
(cherry picked from commit a13b571)
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>


          test/suites/storage_driver_btrfs: don't test copy between pools

e7a6c3b

Fails on GitHub runners with: `ERROR: cannot find parent subvolume`

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>


          test/suites/storage_driver_btrfs: skip --optimized-storage test

b31ae68

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>

simondeziel force-pushed the preparation-for-4.0.10 branch from f6ce644 to b31ae68 Compare

July 10, 2024 03:07

tomponline approved these changes

View reviewed changes

Member

tomponline left a comment

Thanks!

tomponline merged commit 9ec7845 into canonical:stable-4.0

21 of 23 checks passed

simondeziel deleted the preparation-for-4.0.10 branch

July 10, 2024 17:51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.0 LTS API Documentation