-
Notifications
You must be signed in to change notification settings - Fork 931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update first_steps.md #14152
Update first_steps.md #14152
Conversation
The current documentation seems to imply that we are updating snap. I just had to specify that its the lxd snap we're updating to avoid confusion Signed-off-by: Alwoch Sophia <salwoch@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit :)
Also can you please sign Canonical's CLA? |
Signed-off-by: Alwoch Sophia <salwoch@gmail.com>
Heads up @mionaalex - the "Documentation" label was applied to this issue. |
Done! also I've modified it to conform to the convention |
Thanks; can you also rebase the PR into one commit and use the commit title convention that's described here? |
After that, you should be able to push with force: |
@Alwoch Thanks for your contribution! I see that it's your first contribution to Canonical, and I'd love to help you get it ready for merge. Here are detailed instructions to rebase as well as to update the commit message:
Reach out if you have questions. In the interest of completing this change, I will wait a week and if I haven't heard back, I will close this PR and open a new one with attribution to you. |
Hi @minaelee , you can go ahead and open a new PR because I'm avoiding cloning the repository. Thanks |
The current documentation seems to imply that we are updating snap. I just had to specify that its the lxd snap we're updating to avoid confusion