Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lxd/storage: Check for direct I/O when converting image format #14153

Merged
merged 1 commit into from
Sep 25, 2024
Merged

lxd/storage: Check for direct I/O when converting image format #14153

merged 1 commit into from
Sep 25, 2024

Conversation

MusicDin
Copy link
Member

Check for direct I/O when converting image format using qemu-img to bypass OS cache if possible.

@MusicDin
lxd/storage: Check for direct I/O when converting image format
682793e 
Signed-off-by: Din Music <din.music@canonical.com>
@MusicDin
Copy link
Member Author

3 tests are failing due to resize2fs issue. Since conversion is tested only in LXD CI, no test should fail in this repository.

@MusicDin MusicDin marked this pull request as ready for review September 24, 2024 12:55
tomponline
tomponline approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@tomponline tomponline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ta

@tomponline tomponline merged commit d6b1f7f into canonical:main Sep 25, 2024
27 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomponline tomponline tomponline approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MusicDin @tomponline