Remove fanotify warning on ubuntu pro fsmonitor initialisation #14156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markylaing
force-pushed
the
bug-fsmonitor-warning
branch
from
5a5e375
to
b4eac0d
Compare
tomponline
reviewed
Sep 25, 2024
There was a problem hiding this comment.
Is there a reason we cant handle this logic inside fsmonitor itself by detecting if the path being monitored is a mount path (using filesystem.IsMountPoint) and only trying inotify if its not a mount point, rather than expanding the API and putting the burden on the caller to work it out?
Nope. I just didn't think of that... Will change. |
Signed-off-by: Mark Laing <mark.laing@canonical.com>
Signed-off-by: Mark Laing <mark.laing@canonical.com>
… mount point. Signed-off-by: Mark Laing <mark.laing@canonical.com>
markylaing
force-pushed
the
bug-fsmonitor-warning
branch
from
b4eac0d
to
6b9b18b
Compare
simondeziel
approved these changes
Sep 25, 2024
tomponline
reviewed
Sep 25, 2024
tomponline
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the caller to specify a driver when loading an fsmonitor, or they can specify "any" to try to load fanotify but fallback to inotify if it fails.