feat: introduce pgbouncer as a PostgreSQL proxy #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Blocked by: canonical/pgbouncer-operator#245 |
Closed
skatsaounis
force-pushed
the
add-pgbouncer
branch
from
307dd8a to
877b876
Compare
delgod
suggested changes
Jul 2, 2024
I think it is unblocked now |
skatsaounis
force-pushed
the
add-pgbouncer
branch
from
877b876 to
b3ef176
Compare
|
Hi @delgod . Thank you for the hints. The PR has been updated to be able to set them and we will try to merge it soon. |
SK1Y101
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds pgbouncer charm as a subordinate charm of maas-region. Instead of directly communicating with PostgreSQL, MAAS region will use pgbouncer as a proxy. The number of max connections to pgbouncer is configured as relevant to the number of MAAS region nodes of Anvil cluster.
This PR is an enabler for fixing: #11, if not a complete fix at all. In case the default sane values that this PR uses are not enough to fix the starvation issue, the way pgbouncer is introduced, provides a way to override their values. Those overridden values can be passed to pgbouncer through the
manifestmechanism of maas-anvil.