feat: add keepalived to Anvil #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skatsaounis
reviewed
Jun 27, 2024
…---------------------------------
skatsaounis
previously requested changes
Jul 1, 2024
SK1Y101
commented
Jul 1, 2024
Closed
|
@skatsaounis do these changes work for you? |
skatsaounis
force-pushed
the
add-vip
branch
3 times, most recently
from
c2105d3 to
4f7d180
Compare
skatsaounis
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
LGTM with today's changes. It is also passing my local tests successfully. I can set the VIP through the CLI prompt or a manifest. Or I can proceed without specifying a VIP. When I join another haproxy node I also have the option to accept-defaults or remember the previous answer.
@SK1Y101 could you also please take a look at the changes and then merge or update any needed change? Thank you 🙂
|
@skatsaounis the changes look good to me, if it passes the functional tests and you can see the expected behavior in testing I'm happy! |
skatsaounis
changed the title
skatsaounis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the Keepalived charm to MAAS Anvil.
Allow specifying the virtual IP
addresses #10