bug: remove sunbeam leftovers #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skatsaounis
force-pushed
the
remove-sunbeam-leftovers
branch
from
754949d to
2cc6da2
Compare
SK1Y101
previously approved these changes
Jun 19, 2024
skatsaounis
force-pushed
the
remove-sunbeam-leftovers
branch
from
2cc6da2 to
023c0db
Compare
skatsaounis
force-pushed
the
remove-sunbeam-leftovers
branch
from
023c0db to
648f096
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following:
cluster resizecommand which does not apply tomaas-anvilmaas-anvilinstead ofsunbeamNOTE: The microcluster that maas-anvil is using is the sunbeam microcluster. The references to it as
sunbeamwill remain since otherwise a huge refactor of common functions between sunbeam and anvil is required. There is not a huge benefit to do so. In addition, the sunbeam microcluster is used as a whole, without any modification.