Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow node roles different than bootstrapped node #23

Merged
merged 1 commit into from
Jun 27, 2024
Merged

fix: allow node roles different than bootstrapped node #23

merged 1 commit into from
Jun 27, 2024

Conversation

skatsaounis
Copy link
Collaborator

@skatsaounis skatsaounis commented Jun 26, 2024 •
edited
Loading

This PR includes the following:

  • a fix for new nodes that are joining the anvil cluster. Instead of running only the add unit steps of each role, anvil has to also run the terraform init and install application steps. Otherwise, if a new node wants to join with a role that bootstrap node does not have, the usage of only the add unit step fails. At this point, the terraform plan of the role has not been initialized yet and the charmed application has not been installed
  • an overall refactor of bootstrap and join commands to make them more comprehensible

@skatsaounis skatsaounis force-pushed the fix-allow-mixed-node-roles branch 3 times, most recently from c4baaa8 to ed0a287 Compare June 26, 2024 13:20
@skatsaounis skatsaounis marked this pull request as ready for review June 27, 2024 09:04
@skatsaounis skatsaounis requested a review from SK1Y101 June 27, 2024 09:05
SK1Y101
SK1Y101 previously approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@SK1Y101 SK1Y101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Love the changes.

@skatsaounis skatsaounis requested a review from SK1Y101 June 27, 2024 11:24
SK1Y101
SK1Y101 approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@SK1Y101 SK1Y101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 awesome!

@skatsaounis skatsaounis force-pushed the fix-allow-mixed-node-roles branch from 4ab71e8 to f05734d Compare June 27, 2024 12:24
@skatsaounis skatsaounis requested a review from SK1Y101 June 27, 2024 12:24
@skatsaounis skatsaounis merged commit 81bb7a0 into canonical:main Jun 27, 2024
4 checks passed
@skatsaounis skatsaounis deleted the fix-allow-mixed-node-roles branch June 27, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SK1Y101 SK1Y101 SK1Y101 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skatsaounis @SK1Y101