Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add cluster refresh #35

Merged
merged 27 commits into from
Jul 26, 2024
Merged

feat: Add cluster refresh #35

merged 27 commits into from
Jul 26, 2024

Conversation

SK1Y101
Copy link
Member

@SK1Y101 SK1Y101 commented Jul 10, 2024 •
edited
Loading

  • Introduce the command maas-anvil refresh to refresh the configuration of the cluster from a manifest.

Addresses MAASENG-3304

@SK1Y101 SK1Y101 added the enhancement New feature or request label Jul 10, 2024
@SK1Y101 SK1Y101 force-pushed the add-clutser-refresh branch from 66ed651 to 4d76e27 Compare July 11, 2024 14:22
@SK1Y101 SK1Y101 marked this pull request as ready for review July 11, 2024 14:30
SK1Y101
SK1Y101 commented Jul 11, 2024
View reviewed changes
anvil-python/pyproject.toml Outdated Show resolved Hide resolved
wyattrees
wyattrees requested changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@wyattrees wyattrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, but fetching the manifest needs a change

anvil-python/anvil/commands/refresh.py Outdated Show resolved Hide resolved
anvil-python/anvil/commands/refresh.py Outdated Show resolved Hide resolved
@SK1Y101 SK1Y101 force-pushed the add-clutser-refresh branch from 88e143f to f13e0ed Compare July 16, 2024 12:29
@SK1Y101 SK1Y101 requested review from wyattrees and skatsaounis July 19, 2024 08:34
skatsaounis
skatsaounis requested changes Jul 25, 2024
View reviewed changes
Copy link
Collaborator

@skatsaounis skatsaounis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @SK1Y101 . Great job so far. Please take a look at my comments for some small improvements.

anvil-python/anvil/commands/haproxy.py Outdated Show resolved Hide resolved
anvil-python/anvil/commands/refresh.py Outdated Show resolved Hide resolved
anvil-python/anvil/commands/refresh.py Outdated Show resolved Hide resolved
anvil-python/anvil/commands/refresh.py Outdated Show resolved Hide resolved
anvil-python/anvil/commands/refresh.py Show resolved Hide resolved
skatsaounis
skatsaounis approved these changes Jul 26, 2024
View reviewed changes
Copy link
Collaborator

@skatsaounis skatsaounis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

wyattrees
wyattrees approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@wyattrees wyattrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SK1Y101 SK1Y101 merged commit b1858c1 into canonical:main Jul 26, 2024
5 checks passed
@SK1Y101 SK1Y101 deleted the add-clutser-refresh branch July 29, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyattrees wyattrees wyattrees approved these changes

@skatsaounis skatsaounis skatsaounis approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SK1Y101 @skatsaounis @wyattrees