Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add node's ssh key to Juju model on join #38

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

wyattrees
Copy link
Contributor

Uses juju add-ssh-key to add the node's public key to the model, allowing users to ssh to each machine with juju ssh

Copy link
Collaborator

@skatsaounis skatsaounis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the changes look pretty good. I added some comments which can easily be resolved and after that we can merge the PR 🙂

anvil-python/anvil/utils.py Outdated Show resolved Hide resolved
anvil-python/anvil/commands/juju.py Outdated Show resolved Hide resolved
anvil-python/anvil/provider/local/commands.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@skatsaounis skatsaounis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@skatsaounis
Copy link
Collaborator

@wyattrees could you please sign the commits in order to merge this? Feel free to also squash into 1 with only you as a committer. 🙂

@skatsaounis skatsaounis merged commit d796f30 into canonical:main Jul 18, 2024
5 checks passed
@skatsaounis skatsaounis linked an issue Jul 18, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

juju ssh doesnt work from non master maas machine
2 participants