bug: properly wait for removal of units and machines #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skatsaounis
force-pushed
the
wait-removal
branch
from
714aff5 to
3ff8ac0
Compare
skatsaounis
force-pushed
the
wait-removal
branch
from
3ff8ac0 to
9818d99
Compare
|
This is proof of success: https://paste.ubuntu.com/p/v99nNN27Kz/ |
SK1Y101
reviewed
Jul 23, 2024
skatsaounis
force-pushed
the
wait-removal
branch
from
9818d99 to
5d0afdc
Compare
|
A bug was also raised to Juju to describe the existing issue with wait-for and removal of Juju entities: https://bugs.launchpad.net/juju/+bug/2073960 |
skatsaounis
force-pushed
the
wait-removal
branch
from
5d0afdc to
1b5aa11
Compare
wyattrees
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RemoveMachineUnitStepandRemoveJujuMachineStepso that maas-anvil is properly waiting for the removal of units and machines.RemoveJujuMachineStepan extra check is added to ensure that if an error is received during removal, this error is not about the non-existence of the machine. A machine without any units deployed on it is auto-removed. As such, the moment when the command runs, the machine can be already removed.