Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Remove sunbeam from error message in juju-login #48

Merged
merged 3 commits into from
Aug 1, 2024
Merged

refactor: Remove sunbeam from error message in juju-login #48

merged 3 commits into from
Aug 1, 2024

Conversation

SK1Y101
Copy link
Member

@SK1Y101 SK1Y101 commented Aug 1, 2024 •
edited
Loading

  • implement sunbeam.commands.juju_login in anvil using anvil.jobs.checks.VerifyBootstrappedCheck instead.

@SK1Y101
Copy link
Member Author

SK1Y101 commented Aug 1, 2024

Using sunbeam.commands.utils.juju_login worked well, except on a failure would output the message:

Error: Deployment not bootstrapped or bootstrap process has not completed succesfully. Please run sunbeam cluster bootstrap

This implements the same functionality except using the anvil VerifyBootstrappedCheck which includes sanitation of sunbeam in error messages.

skatsaounis
skatsaounis approved these changes Aug 1, 2024
View reviewed changes
Copy link
Collaborator

@skatsaounis skatsaounis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM+1

@SK1Y101 SK1Y101 merged commit 4a412d4 into canonical:main Aug 1, 2024
5 checks passed
@SK1Y101 SK1Y101 deleted the move-login branch August 1, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skatsaounis skatsaounis skatsaounis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SK1Y101 @skatsaounis