Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: fix known issues in refresh command #66

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

refactor: fix known issues in refresh command #66

wants to merge 4 commits into from

Conversation

SK1Y101
Copy link
Member

@SK1Y101 SK1Y101 commented Sep 4, 2024

addresses the following points raised in #61:

  • Blindly adding charms, rather than checking at least one node has the role for that charm
  • Log messages containing "deploy" rather than "refresh"

Still requires modification to handle detecting deployment manifest changes before saving to the database.

May cause merge conflicts with #65

@skatsaounis skatsaounis linked an issue Sep 4, 2024 that may be closed by this pull request
Refresh does not work as expected #61
Open
skatsaounis
skatsaounis reviewed Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@skatsaounis skatsaounis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from two minor suggestions, what about moving this to draft until it fixes all points of the issue? Or the intention is to have a follow-up PR to fix the issue entirely?

anvil-python/anvil/commands/upgrades/intra_channel.py Outdated Show resolved Hide resolved
anvil-python/anvil/commands/upgrades/inter_channel.py Outdated Show resolved Hide resolved
@SK1Y101 SK1Y101 marked this pull request as draft September 6, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skatsaounis skatsaounis skatsaounis left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refresh does not work as expected
2 participants
@SK1Y101 @skatsaounis