Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: TLS passthrough #67

Merged
merged 24 commits into from
Nov 14, 2024
Merged

Conversation

wyattrees
Copy link
Contributor

Adds configuration for passing encrypted requests through HAProxy, to MAAS.

Requires merging of canonical/maas-charms#220. Until it is merged, you can use latest/edge/passthrough-test for the maas-region charm channel

@wyattrees
Copy link
Contributor Author

Note: the git history is a bit messed up on this, since my branch was originally branched off of my TLS Termination branch

anvil-python/anvil/commands/haproxy.py Outdated Show resolved Hide resolved
anvil-python/anvil/commands/haproxy.py Outdated Show resolved Hide resolved
anvil-python/anvil/commands/haproxy.py Outdated Show resolved Hide resolved
anvil-python/anvil/commands/haproxy.py Outdated Show resolved Hide resolved
anvil-python/anvil/commands/haproxy.py Show resolved Hide resolved
anvil-python/anvil/commands/haproxy.py Outdated Show resolved Hide resolved
anvil-python/anvil/commands/haproxy.py Outdated Show resolved Hide resolved
@skatsaounis skatsaounis linked an issue Sep 6, 2024 that may be closed by this pull request
anvil-python/anvil/commands/haproxy.py Outdated Show resolved Hide resolved
anvil-python/anvil/commands/haproxy.py Outdated Show resolved Hide resolved
anvil-python/anvil/commands/haproxy.py Outdated Show resolved Hide resolved
anvil-python/anvil/commands/haproxy.py Show resolved Hide resolved
anvil-python/anvil/commands/haproxy.py Outdated Show resolved Hide resolved
anvil-python/anvil/commands/haproxy.py Show resolved Hide resolved
anvil-python/anvil/commands/haproxy.py Show resolved Hide resolved
anvil-python/anvil/commands/haproxy.py Show resolved Hide resolved
cloud/etc/deploy-maas-region/variables.tf Show resolved Hide resolved
anvil-python/anvil/commands/haproxy.py Show resolved Hide resolved
SK1Y101
SK1Y101 previously approved these changes Sep 24, 2024
Copy link
Member

@SK1Y101 SK1Y101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not much extra to add, looks good

anvil-python/anvil/commands/haproxy.py Show resolved Hide resolved
Copy link
Collaborator

@skatsaounis skatsaounis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of the comments. I added a couple more but hopefully the last ones. In addition to those, could you also rebase to latest main?

anvil-python/anvil/commands/haproxy.py Outdated Show resolved Hide resolved
anvil-python/anvil/commands/haproxy.py Outdated Show resolved Hide resolved
anvil-python/anvil/commands/haproxy.py Outdated Show resolved Hide resolved
anvil-python/anvil/commands/haproxy.py Show resolved Hide resolved
anvil-python/anvil/commands/maas_region.py Show resolved Hide resolved
anvil-python/anvil/commands/haproxy.py Outdated Show resolved Hide resolved
wyattrees and others added 20 commits October 3, 2024 10:36
…es. Set tls config via settings yaml crts directory.

Add instructions for TLS termination to README
…it's end. Change agent-service to agent_service to comply with underscore convention
…epath. Let maas-region handle creating the files in the proper place
…pty string instead of None. Make default tls_mode value 'disabled' instead of empty string
… in preseed and manifest, and create section for maas-region in preseed/manifest. do not pass CA cert to ha proxy charm variables
Copy link
Collaborator

@skatsaounis skatsaounis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@skatsaounis skatsaounis merged commit 2146002 into canonical:main Nov 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature-request] Enable TLS in MAAS
3 participants