Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rename --name and --manifest-file flags to be more explicit #75

Merged
merged 1 commit into from
Nov 13, 2024
Merged

fix: rename --name and --manifest-file flags to be more explicit #75

merged 1 commit into from
Nov 13, 2024

Conversation

wyattrees
Copy link
Contributor

Changes the --name flag to --fqdn for commands maas-anvil cluster add and maas-anvil cluster remove, and changes the --manifest-file flag to --output for maas-anvil manifest generate.

Addresses #72

@skatsaounis skatsaounis linked an issue Nov 13, 2024 that may be closed by this pull request
Rename flags to be more explicit #72
Closed
skatsaounis
skatsaounis approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@skatsaounis skatsaounis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@skatsaounis skatsaounis merged commit e4066f4 into canonical:main Nov 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skatsaounis skatsaounis skatsaounis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename flags to be more explicit
2 participants
@wyattrees @skatsaounis