minio: Adds additional minio tenant user #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when the minio krew plugin was used to deploy the minio tenant, the krew plugin created an additional user, with the credentials set in the $TENANT_NAME-user-1 Kubernetes secret. The Helm chart we're using does not do that by default, but it does accept a list of Kubernetes secrets with CONSOLE_ACCESS_KEY (user) and CONSOLE_SECRET_KEY (password) fields set in them. With this change, we're now creating the secret ourselves, and passing it onto the Helm chart. The minio tenant will have this new user, in addition to the regular root user. With this, the behaviour that the krew plugin had is preserved. Additionally, remvoes reference to the kubectl-minio plugin since it doesn't exist anymore.
claudiubelu
added a commit
to claudiubelu/microk8s-core-addons
that referenced
this pull request
Oct 3, 2024
Previously, when the minio krew plugin was used to deploy the minio tenant, the krew plugin created an additional user, with the credentials set in the $TENANT_NAME-user-1 Kubernetes secret. The Helm chart we're using does not do that by default, but it does accept a list of Kubernetes secrets with CONSOLE_ACCESS_KEY (user) and CONSOLE_SECRET_KEY (password) fields set in them. With this change, we're now creating the secret ourselves, and passing it onto the Helm chart. The minio tenant will have this new user, in addition to the regular root user. With this, the behaviour that the krew plugin had is preserved. Additionally, remvoes reference to the kubectl-minio plugin since it doesn't exist anymore. (cherry picked from commit 8340271)
claudiubelu
added a commit
to claudiubelu/microk8s-core-addons
that referenced
this pull request
Oct 3, 2024
Previously, when the minio krew plugin was used to deploy the minio tenant, the krew plugin created an additional user, with the credentials set in the $TENANT_NAME-user-1 Kubernetes secret. The Helm chart we're using does not do that by default, but it does accept a list of Kubernetes secrets with CONSOLE_ACCESS_KEY (user) and CONSOLE_SECRET_KEY (password) fields set in them. With this change, we're now creating the secret ourselves, and passing it onto the Helm chart. The minio tenant will have this new user, in addition to the regular root user. With this, the behaviour that the krew plugin had is preserved. Additionally, remvoes reference to the kubectl-minio plugin since it doesn't exist anymore. (cherry picked from commit 8340271)
claudiubelu
added a commit
to claudiubelu/microk8s-core-addons
that referenced
this pull request
Oct 3, 2024
Previously, when the minio krew plugin was used to deploy the minio tenant, the krew plugin created an additional user, with the credentials set in the $TENANT_NAME-user-1 Kubernetes secret. The Helm chart we're using does not do that by default, but it does accept a list of Kubernetes secrets with CONSOLE_ACCESS_KEY (user) and CONSOLE_SECRET_KEY (password) fields set in them. With this change, we're now creating the secret ourselves, and passing it onto the Helm chart. The minio tenant will have this new user, in addition to the regular root user. With this, the behaviour that the krew plugin had is preserved. Additionally, remvoes reference to the kubectl-minio plugin since it doesn't exist anymore. (cherry picked from commit 8340271)
berkayoz
pushed a commit
that referenced
this pull request
Oct 4, 2024
berkayoz
pushed a commit
that referenced
this pull request
Oct 4, 2024
berkayoz
pushed a commit
that referenced
this pull request
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when the minio krew plugin was used to deploy the minio tenant, the krew plugin created an additional user, with the credentials set in the
$TENANT_NAME-user-1Kubernetes secret.The Helm chart we're using does not do that by default, but it does accept a list of Kubernetes secrets with
CONSOLE_ACCESS_KEY(user) andCONSOLE_SECRET_KEY(password) fields set in them.With this change, we're now creating the secret ourselves, and passing it onto the Helm chart. The minio tenant will have this new user, in addition to the regular root user. With this, the behaviour that the krew plugin had is preserved.
Additionally, remvoes reference to the
kubectl-minioplugin since it doesn't exist anymore.Thank you for making MicroK8s better
Please reference the issue this PR is fixing, or provide a description of the problem addressed.
Also verify you have: