Skip to content

Commit

Permalink
ASan: Don't do leak checking
Browse files Browse the repository at this point in the history
Sadly, we *know* we have benign leaks in hard-to-fix places. It would still
be valuable to fail CI if ASan detects anything *else* - out of bounds writes,
use-after-free, etc.

Disable the leak checker so we can mark ASan failures as CI-fatal.
Hopefully we can get get the leaks fixed or correctly-suppressed *some*time!
  • Loading branch information
RAOF authored and Saviq committed Nov 8, 2023
1 parent 231f1b0 commit e761d39
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion spread/build/ubuntu/task.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,6 @@ execute: |
echo "OVERRIDE_CONFIGURE_OPTIONS += -DCMAKE_CXX_COMPILER_LAUNCHER=ccache" >> debian/opts.mk
# build and run tests
UBSAN_OPTIONS=halt_on_error=1 debian/rules build
UBSAN_OPTIONS=halt_on_error=1 ASAN_OPTIONS=detect_leaks=0 debian/rules build
ccache --show-stats --zero-stats > ${CCACHE_DIR}/ccache.stats

0 comments on commit e761d39

Please sign in to comment.