[wayland platform] Less broken display on scaled hosts #3037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3037 +/- ##
=======================================
Coverage 77.70% 77.71%
=======================================
Files 1056 1056
Lines 73394 73397 +3
=======================================
+ Hits 57030 57037 +7
+ Misses 16364 16360 -4
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
The alpine-edge failure is fixed by #3038 |
AlanGriffiths
force-pushed
the
fix-3036
branch
from
d10aff8
to
644e822
Compare
mattkae
requested changes
Sep 12, 2023
| @@ -718,7 +719,8 @@ void mgw::DisplayClient::pointer_enter( | |||
| { | |||
| if (surface == out.second->surface) | |||
| { | |||
| pointer_displacement = out.second->dcout.top_left - geometry::Point{}; | |||
| pointer_displacement = geom::DisplacementF{out.second->dcout.top_left - geometry::Point{}}; | |||
| host_scale = out.second->host_scale; | |||
There was a problem hiding this comment.
Why are we setting the host_scale during pointer_enter?
AlanGriffiths
force-pushed
the
fix-3036
branch
from
644e822
to
d0407f7
Compare
mattkae
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't confuse scaling of host environment with internal scaling of outputs.
Fixes: #3036
Note: this fixes the display and cursor positioning and so is generally an improvement. However, there are remaining oddities with the cursor image. These are arguably pre-existing, and don't make things unusable