Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debian: package atomic-kms #3607

Merged
merged 2 commits into from
Oct 23, 2024
Merged

debian: package atomic-kms #3607

merged 2 commits into from
Oct 23, 2024

Conversation

Saviq
Copy link
Collaborator

@Saviq Saviq commented Sep 23, 2024

No description provided.

@Saviq Saviq requested a review from a team as a code owner September 23, 2024 16:26
@Saviq Saviq added the triaged Triage into JIRA to plan it in label Oct 7, 2024
RAOF
RAOF requested changes Oct 14, 2024
View reviewed changes
debian/control Show resolved Hide resolved
@Saviq Saviq force-pushed the package-atomic-kms-platform branch from 926ec51 to 5ea4fe1 Compare October 14, 2024 08:12
RAOF
RAOF requested changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@RAOF RAOF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unknown package: debian/control contains versioned package mir-platform-graphics-atomic-kms but it is unknown to this script

We'll need to fix this before it can land 😉

debian/control Show resolved Hide resolved
@Saviq Saviq force-pushed the package-atomic-kms-platform branch from 0e9cf29 to f5b9689 Compare October 15, 2024 15:11
@Saviq Saviq force-pushed the package-atomic-kms-platform branch from f5b9689 to 210c368 Compare October 17, 2024 08:31
@Saviq
debian: make atomic depend on gbm-kms
35c2d22 
We need the egl rendering platform from there.
@Saviq Saviq requested a review from RAOF October 17, 2024 10:32
AlanGriffiths
AlanGriffiths approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@AlanGriffiths AlanGriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, looks fine now

@AlanGriffiths AlanGriffiths merged commit 8082102 into initial-atomic-kms-platform Oct 23, 2024
38 checks passed
@AlanGriffiths AlanGriffiths deleted the package-atomic-kms-platform branch October 23, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlanGriffiths AlanGriffiths AlanGriffiths approved these changes

@tarek-y-ismail tarek-y-ismail Awaiting requested review from tarek-y-ismail

@RAOF RAOF Awaiting requested review from RAOF

Assignees
No one assigned
Labels
triaged Triage into JIRA to plan it in
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Saviq @RAOF @AlanGriffiths