Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 2.18.3 #3624

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Release 2.18.3 #3624

merged 2 commits into from
Oct 14, 2024

Conversation

Saviq
Copy link
Collaborator

@Saviq Saviq commented Oct 7, 2024

Enhancements:

AlanGriffiths and others added 2 commits October 7, 2024 15:04
@AlanGriffiths @Saviq
Ensure windows are placed and repainted on X11 "CONFIGURE" (#3619)
4c9b49b 
We are

1. Leaking the X11 `CONFIGURE` placement through (when we should be
ignoring it); and,
2. Not properly placing windows that `CONFIGURE` to fullscreen when they
are already forced to be fullscreen.

This works around these problems in the least invasive way.
@Saviq
Release 2.18.3
877a2c9
@Saviq Saviq requested a review from a team as a code owner October 7, 2024 13:07
AlanGriffiths
AlanGriffiths approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@AlanGriffiths AlanGriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup. Don't think we're missing anything else

@Saviq Saviq added this pull request to the merge queue Oct 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 14, 2024
@Saviq Saviq added this pull request to the merge queue Oct 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 14, 2024
@AlanGriffiths AlanGriffiths added this pull request to the merge queue Oct 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 14, 2024
@AlanGriffiths AlanGriffiths merged commit ee62c72 into main Oct 14, 2024
60 checks passed
@AlanGriffiths AlanGriffiths deleted the release/2.18 branch October 14, 2024 16:43
@Saviq Saviq restored the release/2.18 branch October 18, 2024 13:09
@Saviq Saviq mentioned this pull request Oct 18, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Oct 18, 2024
@tarek-y-ismail
2.18.3 fixup (#3643)
5590424 
Somehow #3624 wasn't the tagged commit… so fix that now.
@tarek-y-ismail tarek-y-ismail deleted the release/2.18 branch October 18, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlanGriffiths AlanGriffiths AlanGriffiths approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Saviq @AlanGriffiths