[DPE-5237] implement revision check for sharding components #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiaAltieri
force-pushed
the
DPE-5237-revision-check
branch
from
55f8de0
to
43cea1e
Compare
MiaAltieri
changed the title
MiaAltieri
force-pushed
the
DPE-5237-revision-check
branch
2 times, most recently
from
0fb5c64
to
bb1484a
Compare
MiaAltieri
force-pushed
the
DPE-5237-revision-check
branch
from
bb1484a
to
6f78f2b
Compare
Gu1nness
previously approved these changes
Sep 12, 2024
Mehdi-Bendriss
approved these changes
Sep 12, 2024
Mehdi-Bendriss
requested changes
Sep 12, 2024
Gu1nness
previously approved these changes
Sep 13, 2024
Co-authored-by: Mehdi Bendriss <bendrissmehdi@gmail.com>
MiaAltieri
force-pushed
the
DPE-5237-revision-check
branch
from
d08128d
to
a6db84e
Compare
Mehdi-Bendriss
approved these changes
Sep 13, 2024
Gu1nness
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Users can integrate shards with config-servers of different revisions. This is an issue because different revisions offer different features
Solution
Implement a check to verify if components are from the same revision