Open shell button starts the VM if needed
#3830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3830 +/- ##
==========================================
- Coverage 88.95% 88.94% -0.01%
==========================================
Files 256 256
Lines 14584 14584
==========================================
- Hits 12973 12972 -1
- Misses 1611 1612 +1 ☔ View full report in Codecov by Sentry. |
andrei-toterman
force-pushed
the
fix-http2-connection-disconnected
branch
from
ca75b7a to
a2ecad8
Compare
andrei-toterman
force-pushed
the
gui-open-shell-start-vm
branch
from
728546d to
37831d4
Compare
andrei-toterman
force-pushed
the
fix-http2-connection-disconnected
branch
from
a2ecad8 to
8fab6a6
Compare
andrei-toterman
force-pushed
the
gui-open-shell-start-vm
branch
from
37831d4 to
c119f93
Compare
Sploder12
previously approved these changes
Dec 10, 2024
andrei-toterman
force-pushed
the
fix-http2-connection-disconnected
branch
from
8fab6a6 to
0e909a0
Compare
andrei-toterman
force-pushed
the
gui-open-shell-start-vm
branch
from
c119f93 to
bb77155
Compare
levkropp
previously approved these changes
Dec 16, 2024
andrei-toterman
force-pushed
the
fix-http2-connection-disconnected
branch
from
2c63e3d to
acf4d8f
Compare
andrei-toterman
force-pushed
the
gui-open-shell-start-vm
branch
from
bb77155 to
a9bd618
Compare
andrei-toterman
force-pushed
the
fix-http2-connection-disconnected
branch
from
acf4d8f to
7f7d7fd
Compare
andrei-toterman
force-pushed
the
gui-open-shell-start-vm
branch
from
a9bd618 to
859eef1
Compare
andrei-toterman
dismissed stale reviews from levkropp and Sploder12
The base branch was changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, if the VM is in a state from which it can be started (
StoppedorSuspended), theOpen shellbutton will be enabled and it will start the VM before shelling into it.MULTI-1681