Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPE-1771] Minor version upgrades #147

Merged
merged 25 commits into from
Oct 10, 2023
Merged

[DPE-1771] Minor version upgrades #147

merged 25 commits into from
Oct 10, 2023

Conversation

dragomirp
Copy link
Contributor

@dragomirp dragomirp commented Sep 29, 2023

Minor version upgrades for PGB.

Since the upgrade process requires patching K8S resources the charm will require trust now

@dragomirp dragomirp changed the title [DPE-1771] upgrades [DPE-1771] Minor version upgrades Sep 29, 2023
@@ -73,6 +73,7 @@ async def test_database_relation_with_charm_libraries(ops_test: OpsTest, pgb_cha
application_name=PGB,
num_units=2,
series=CHARM_SERIES,
trust=True,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not strictly necessary yet, but it will become so when we start patching the ports.

Comment on lines 218 to 219
@pytest.mark.unstable
async def test_relation_with_openldap(ops_test: OpsTest):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The openldap consistently fails, in other PRs as well. Created DPE-2685 to investigate.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, it was a Canonical registry migration, should no longer be reproducible. 🤞

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple sanity check test.

Comment on lines +126 to +131
Client().patch(
StatefulSet,
name=self.charm.model.app.name,
namespace=self.charm.model.name,
obj=patch,
)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This requires --trust

@dragomirp dragomirp marked this pull request as ready for review October 2, 2023 11:47
Copy link
Member

@marceloneppel marceloneppel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

self._cluster_checks()

try:
self._set_rolling_update_partition(self.charm.app.planned_units() - 1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question: doesn't this trigger the upgrade in the last two units before it's needed to call the resume-upgrade action?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a copy paste from the Postgresql charm. I haven't noticed it while testing and the integration test seems to upgrade the first unit only after resume-upgrade was issued.

actions.yaml Show resolved Hide resolved
Copy link
Contributor

@taurus-forever taurus-forever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! THANK YOU!

@dragomirp dragomirp merged commit 886a1f6 into main Oct 10, 2023
@dragomirp dragomirp deleted the dpe-1771-upgrades branch October 10, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants