-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DPE-1771] Minor version upgrades #147
Conversation
27ee241
to
3708558
Compare
@@ -73,6 +73,7 @@ async def test_database_relation_with_charm_libraries(ops_test: OpsTest, pgb_cha | |||
application_name=PGB, | |||
num_units=2, | |||
series=CHARM_SERIES, | |||
trust=True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not strictly necessary yet, but it will become so when we start patching the ports.
@pytest.mark.unstable | ||
async def test_relation_with_openldap(ops_test: OpsTest): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The openldap consistently fails, in other PRs as well. Created DPE-2685 to investigate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO, it was a Canonical registry migration, should no longer be reproducible. 🤞
tests/integration/test_upgrade.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple sanity check test.
Client().patch( | ||
StatefulSet, | ||
name=self.charm.model.app.name, | ||
namespace=self.charm.model.name, | ||
obj=patch, | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This requires --trust
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
self._cluster_checks() | ||
|
||
try: | ||
self._set_rolling_update_partition(self.charm.app.planned_units() - 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a question: doesn't this trigger the upgrade in the last two units before it's needed to call the resume-upgrade
action?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a copy paste from the Postgresql charm. I haven't noticed it while testing and the integration test seems to upgrade the first unit only after resume-upgrade
was issued.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! THANK YOU!
Minor version upgrades for PGB.
Since the upgrade process requires patching K8S resources the charm will require trust now