Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DPE-2844] Split indico and extension blocking tests #163

Merged
merged 2 commits into from
Nov 24, 2023
Merged

[DPE-2844] Split indico and extension blocking tests #163

merged 2 commits into from
Nov 24, 2023

Conversation

dragomirp
Copy link
Contributor

@dragomirp dragomirp commented Nov 22, 2023 •
edited
Loading

Issue

  • Indico switched to data_interfaces
  • No other tests test blocking on extensions in legacy interface

Solution

Port the split test from PG

@dragomirp dragomirp marked this pull request as ready for review November 22, 2023 15:00
taurus-forever
taurus-forever approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@taurus-forever taurus-forever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@dragomirp dragomirp merged commit 1c9704f into main Nov 24, 2023
20 checks passed
@dragomirp dragomirp deleted the dpe-2844-indico branch November 24, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marceloneppel marceloneppel marceloneppel approved these changes

@taurus-forever taurus-forever taurus-forever approved these changes

Assignees
No one assigned
Labels
Libraries: OK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dragomirp @taurus-forever @marceloneppel