[MISC] Reusable workflow #168
Conversation
| juju: | ||
| - agent: 2.9.46 | ||
| libjuju: ^2 | ||
| - agent: 3.1.6 |
There was a problem hiding this comment.
Backend relation fails on 3.1.7. Will investigate separately.
| @@ -22,14 +23,14 @@ | |||
|
|
|||
| logger = logging.getLogger(__name__) | |||
|
|
|||
| FIRST_DISCOURSE_APP_NAME = "discourse-k8s" | |||
There was a problem hiding this comment.
discourse-k8s was ported to the new interface.
There was a problem hiding this comment.
Crazy naming choise... BTW, is "discourse-k8s" R.I.P? Why do we need two identical charms? o_0
There was a problem hiding this comment.
Discourse-k8s is the actively developed charm and has switched to the new data interface. We have added a new test for it in the PG charm, we'll have to do so for PGB as well, but that's out of scope for the PR.
dragomirp
requested review from
marceloneppel,
carlcsaposs-canonical and
taurus-forever
| @@ -22,14 +23,14 @@ | |||
|
|
|||
| logger = logging.getLogger(__name__) | |||
|
|
|||
| FIRST_DISCOURSE_APP_NAME = "discourse-k8s" | |||
There was a problem hiding this comment.
Crazy naming choise... BTW, is "discourse-k8s" R.I.P? Why do we need two identical charms? o_0
| { | ||
| "matchPackageNames": ["pydantic"], | ||
| "allowedVersions": "<2.0.0" | ||
| }, { |
There was a problem hiding this comment.
permanent ignores for temporary issues make me worried that we'll forget about them
maybe a better option would be to manually close the PR that renovate opens so that it adds it to the ignore list?
at the least, I'd suggest adding a comment to explain why this ignore was added
There was a problem hiding this comment.
I don't consider this a temporary issue. There are multiple charm libs that will need to be updated to work with pydantic 2 and it also fails to compile with focal's rustc. I doubt we can make the jump anytime soon.
| "matchPackageNames": ["python"], | ||
| "allowedVersions": "<3.11" |
There was a problem hiding this comment.
consider disabling python updates instead—maybe we should add this to shared config
There was a problem hiding this comment.
The python version is charm specific, it will vary depending on the base.
There was a problem hiding this comment.
My suggestion is to disable automatic python updates for all charms
.github/renovate.json5
Outdated
| "regexManagers": [ | ||
| { | ||
| "fileMatch": ["(^|/)([\\w-]*)charmcraft\\.ya?ml$"], | ||
| "matchStrings": ["- (?<depName>.*?)(?:\\[.*?\\])?==(?<currentValue>.*?) +# renovate"], | ||
| "datasourceTemplate": "pypi", | ||
| "versioningTemplate": "loose" | ||
| } | ||
| ] |
There was a problem hiding this comment.
fyi charm-strict-dependencies will change how binary packages are managed
would recommend enabling strict dependencies if they don't cause issues
Co-authored-by: Carl Csaposs <carl.csaposs@canonical.com>
|
Enabled |
dragomirp
requested review from
taurus-forever,
marceloneppel and
carlcsaposs-canonical
There was a problem hiding this comment.
looks good for v8
fyi for v9: https://chat.canonical.com/canonical/pl/83744yqxut8mxk4dsxb9q3nfie
pyproject.toml
Outdated
| psycopg-binary = "^3.1.17" | ||
| psycopg = {extras = ["binary"], version = "^3.1.17"} |
There was a problem hiding this comment.
are both of these needed?
Switch to the DPW reusable workflow